-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) fix failing tests because of new year #1424
Conversation
Size Change: 0 B Total Size: 7.26 MB ℹ️ View Unchanged
|
119a1f7
to
4e58da0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done, @chibongho! Thanks.
b5bbf2a
to
f7eed1a
Compare
@chibongho just so you don't sink any more time into this, these tests are likely failing because dev3 is down (which is down because Jetstream is down). No fault of our own AFAICT. |
That's odd... on the one hand, I can't see how these changes cause the e2e test failures; on the other, the e2e tests themselves should be completely independent of dev3. |
Might this |
Yes actually! That's got to be output from this line:
Looks like maybe the
The failures in the e2e tests are because none of the apps from the openmrs-esm-patient-management repo are being added, so they can't be interacted with. |
Btw, @chibongho, I love the branch name! |
A sentiment shared by most on the eng leads call today :) |
Requirements
Summary
Fixes the unit test data (specifically test patients' ages) to be more resilient against new year.
Screenshots
Related Issue
Other